Merged
Conversation
BrennanConroy
added
the
area-infrastructure
jkotalik
added
the
Servicing-consider
leecow
added
Servicing-approved
BrennanConroy
requested review from
a team,
JunTaoLuo,
analogrelay and
jkotalik
dougbu
reviewed
Feb 13, 2020
| @@ -26,6 +26,9 @@ | |||
| <ItemGroup> | |||
| <Reference Include="Microsoft.AspNetCore.AzureAppServices.SiteExtension.2.1" Version="$(MicrosoftAspNetCoreAzureAppServicesSiteExtension21PackageVersion)" PrivateAssets="All" /> | |||
| <Reference Include="Microsoft.AspNetCore.AzureAppServices.SiteExtension.2.2" Version="$(MicrosoftAspNetCoreAzureAppServicesSiteExtension22PackageVersion)" PrivateAssets="All" /> | |||
Contributor
There was a problem hiding this comment.
Is this reference still needed?
Member
Author
There was a problem hiding this comment.
I think we decided to keep it for now
| $(RepoRoot)src\Servers\**\*.csproj; | ||
| $(RepoRoot)src\Security\**\*.*proj; | ||
| $(RepoRoot)src\SiteExtensions\Microsoft.Web.Xdt.Extensions\**\*.csproj; | ||
| $(RepoRoot)src\SiteExtensions\LoggingAggregate\test\**\*.csproj; |
Contributor
There was a problem hiding this comment.
Was this test previously skipped because the project wasn't built?
Member
Author
There was a problem hiding this comment.
I think it was just missed? I'm not sure
Contributor
|
|
from my perspective but needs approval from someone more familiar w/ this area
analogrelay
added
Servicing-approved
Member
Author
|
Ping reviewers, needs approval |
wtgodbe
approved these changes
Feb 14, 2020
analogrelay
approved these changes
Feb 14, 2020
Contributor
|
I just double-checked this PR and it looks good 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15381